Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix version bug #13098

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Fix version bug #13098

merged 6 commits into from
Feb 12, 2025

Conversation

Wuyunfan-BUPT
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

  • Request will be automatically failed cased by a deprecated version of actions/upload-artifact: v3;
  • "actions/upload-artifact: v3" and "actions/github-script@v3.1.0" do not match which will result in pipeline failure;
  • The repository will not be found result of "https://ghproxy.com".

Brief changelog

  • change actions/upload-artifact version from v3 to v4;
  • change actions/github-script version from v3 to v6;
  • delete "https://ghproxy.com".

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (5c0fa0d) to head (0d70b03).
Report is 52 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13098      +/-   ##
=============================================
- Coverage      72.62%   72.27%   -0.36%     
- Complexity      9802    10021     +219     
=============================================
  Files           1278     1310      +32     
  Lines          41015    42011     +996     
  Branches        4330     4412      +82     
=============================================
+ Hits           29787    30363     +576     
- Misses          9165     9543     +378     
- Partials        2063     2105      +42     

see 167 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0fa0d...0d70b03. Read the comment docs.

@KomachiSion KomachiSion merged commit 12c455b into alibaba:develop Feb 12, 2025
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants