New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(rax-scripts): command line option "--output-path" not working #1045

Merged

yuanyan merged 1 commit into alibaba:master from Clarence-pan:patch-1

Apr 23, 2019

Contributor

Clarence-pan commented Apr 22, 2019

The "--output-path" option of "rax-scripts" was not working. I've found the reason, and figured out a
simple solution.

Before submitting a pull request, please make sure the following is done...

Fork the repo and create your branch from master.
If you've added code that should be tested, add tests!
If you've changed APIs, update the documentation.
Ensure the test suite passes (npm test).
Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.


          fix(rax-scripts): command line option "--output-path" not working

204538c

wssgcg1213 approved these changes

View reviewed changes

Collaborator

wssgcg1213 left a comment

这里可以这么做的原因是 cli 里面把参数映射到 env 里了, 这种有副作用的映射可能会导致一些不可预知的问题, 不过这是另一个话题了.

I would approve this change.

yuanyan merged commit 914558c into alibaba:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet