Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: match search is not needed #1166

Merged
merged 1 commit into from
Jul 30, 2019
Merged

fix: match search is not needed #1166

merged 1 commit into from
Jul 30, 2019

Conversation

yundongbot
Copy link
Collaborator

匹配路由时应该只需要匹配 pathname 即可，search 不需要强制匹配：

// routers
[
   {
      path: '/search',
      component: () => <Search />,
    }
]

可以匹配到

http://localhost:9999/search
http://localhost:9999/search?q=xxx
http://localhost:9999/search?q=xxx&any_query=xxxx

当前版本无法匹配带 query 的情况。

@wssgcg1213 wssgcg1213 requested a review from yuanyan July 29, 2019 11:24
wssgcg1213
wssgcg1213 requested changes Jul 29, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测挂了, 看一下 ci 的问题

wssgcg1213
wssgcg1213 approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanyan yuanyan merged commit 1296eeb into alibaba:master Jul 30, 2019
@weekly-digest weekly-digest bot mentioned this pull request Aug 4, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@yuanyan yuanyan Awaiting requested review from yuanyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yundongbot @wssgcg1213 @yuanyan