Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add rax-set-native-props & rax-get-element-by-id #1296

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Conversation

yacheng
Copy link
Collaborator

@yacheng yacheng commented Aug 27, 2019

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@yacheng yacheng requested a review from wssgcg1213 August 27, 2019 06:16
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@yuanyan yuanyan merged commit 50c84a7 into master Aug 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-set-native-props branch August 27, 2019 08:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants