Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: update exception when rise a element type error #1455

Merged
merged 6 commits into from
Nov 1, 2019

Conversation

yuanyan
Copy link
Collaborator

@yuanyan yuanyan commented Oct 30, 2019

Fix below code that will make rax update exception:

const App = () => {
  const [data, setData] = useState('string');

  console.log('Host.__isUpdating', shared.Host.__isUpdating);
  return (
    <div onClick={() => {
      setData({ a: 2 });
    }}>
      Hello World
      <span>{data}</span>
    </div>
  );
};

@yuanyan yuanyan requested review from yongningfu and wssgcg1213 and removed request for yongningfu October 30, 2019 11:00
@wssgcg1213
Copy link
Collaborator

Test case required.

@yuanyan yuanyan merged commit 8489a23 into master Nov 1, 2019
@yuanyan yuanyan deleted the fix-rax-update-exception branch November 1, 2019 06:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants