feat: component generator & universal build #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssgcg1213
reviewed
Mar 6, 2019
| ], | ||
| }, | ||
| // JSON is not enabled by default in Webpack but both Node and Browserify | ||
| // allow it implicitly so we also enable it. |
There was a problem hiding this comment.
Since webpack >= v2.0.0, importing of JSON files will work by default
| @@ -72,6 +72,10 @@ function getConfig(entry, output, moduleOptions, babelLoaderQuery, target, devto | |||
| }; | |||
| } | |||
|
|
|||
|
|
|||
| babelOptions.presets[1][1].modules = 'commonjs'; | |||
| babelOptions.plugins.push('add-module-exports'); | |||
There was a problem hiding this comment.
do not do this to modify a reference object.
| *.log | ||
|
|
||
| .DS_Store | ||
| .idea/ |
There was a problem hiding this comment.
把.idea丢到ignore里其实不是一种好的做法, ide的配置可能包含一些编码习惯, 同一个项目的编码习惯在团队中互相共享有助于保持项目代码的一致性, 不过我们现在好像都是这么做的, 只是提出一下, 可以先不改
|
take a look in travis-ci. |
yuanyan
reviewed
Apr 17, 2019
| </style> | ||
| </head> | ||
| <body> | ||
| <script src="https://g.alicdn.com/code/npm/web-rax-framework/0.6.4/dist/framework.web.min.js"></script> |
yuanyan
reviewed
Apr 17, 2019
| @@ -48,6 +48,7 @@ const paths = { | |||
| appSrc: resolveApp('src'), | |||
| appManifest: resolveApp('manifest.json'), | |||
| appNodeModules: resolveApp('node_modules'), | |||
| componentIndexJs: resolveModule(resolveApp, 'public/index'), | |||
yuanyan
reviewed
Apr 17, 2019
| ], | ||
| }, | ||
| { | ||
| test: /\.(sfc|vue|html)$/, |
There was a problem hiding this comment.
sfc相关的应该可以不需要了，参考最新的webapp的配置脚本
yuanyan
reviewed
Apr 17, 2019
| @@ -0,0 +1,53 @@ | |||
| const type = process.env.TYPE; | |||
There was a problem hiding this comment.
babel文件应该是共享的，参考整体目录结构，不应该重复
yuanyan
reviewed
Apr 17, 2019
| "babel-plugin-add-module-exports": "1.0.0", | ||
| "eslint": "^5.10.0", | ||
| "eslint-plugin-import": "^2.14.0", | ||
| "eslint-plugin-react": "~7.11.1", |
There was a problem hiding this comment.
这些包不应该加到scripts里的依赖，这些是项目生成后里的依赖
There was a problem hiding this comment.
这部分之前考虑是 rax-scripts 也承担 lint 的工作，目前不考虑 lint 我先去掉
yuanyan
reviewed
Apr 17, 2019
packages/rax-scripts/package.json
Outdated
| @@ -32,6 +32,10 @@ | |||
| "@babel/preset-flow": "7.0.0", | |||
| "@babel/preset-react": "7.0.0", | |||
| "@babel/runtime": "^7.2.0", | |||
| "babel-plugin-add-module-exports": "1.0.0", | |||
yuanyan
reviewed
Apr 17, 2019
| @@ -8,4 +8,5 @@ program | |||
| .usage('<command> [options]') | |||
| .command('build', 'Build project in production mode') | |||
| .command('start', 'Start a web server in development mode (hot-reload and inline-module-source-map is enable default)') | |||
| .command('lint', 'Lint for component code') | |||
yuanyan
reviewed
Apr 17, 2019
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env node | |||
yuanyan
reviewed
Apr 17, 2019
| @@ -0,0 +1,23 @@ | |||
| import {Component, createElement, PropTypes, render} from 'rax'; | |||
There was a problem hiding this comment.
PropTypes, render 没有用到，不应该import进来
yuanyan
reviewed
Apr 17, 2019
| import renderer from 'rax-test-renderer'; | ||
| import Mod from '../'; | ||
|
|
||
| describe('Mod', () => { |
yuanyan
reviewed
Apr 17, 2019
| import Mod from '../'; | ||
|
|
||
| describe('Mod', () => { | ||
| it('test typeof Mod', () => { |
There was a problem hiding this comment.
“test typeof Mod” 表达需要优化下
yuanyan
reviewed
Apr 24, 2019
| @@ -48,6 +48,7 @@ const paths = { | |||
| appSrc: resolveApp('src'), | |||
| appManifest: resolveApp('manifest.json'), | |||
| appNodeModules: resolveApp('node_modules'), | |||
| componentDemoJs: resolveModule(resolveApp, 'public/index'), | |||
There was a problem hiding this comment.
demo js 是不是可以考虑放到 src/demo.js 或 src/demo/index.js 或 demo/index.js
yuanyan
reviewed
Apr 24, 2019
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1, minimum-scale=1, user-scalable=no"> | ||
| <title>Rax Component Demo</title> | ||
| <script src="//g.alicdn.com/code/npm/web-rax-framework/0.6.5/dist/framework.web.js"></script> |
yuanyan
reviewed
Apr 24, 2019
| @@ -17,6 +17,14 @@ var entry = {}; | |||
| entry[entryName] = entry[entryName + '.min'] = entry[entryName + '.factory'] = main; | |||
| var globalName = uppercamelcase(packageName); | |||
|
|
|||
| babelOptions.presets.push([ | |||
yuanyan
reviewed
Apr 24, 2019
| @@ -0,0 +1,23 @@ | |||
| // jest.config.js | |||
There was a problem hiding this comment.
jest 配置可以考虑不对 component 级别暴露
yuanyan
reviewed
Apr 25, 2019
packages/rax-scripts/src/lint.js
Outdated
| @@ -0,0 +1,213 @@ | |||
| var cliObject = { | |||
…into feat-universal-build
yuanyan
approved these changes
Apr 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.