Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rax-cli v1.0.0 #972

Merged
merged 4 commits into from
Mar 12, 2019
Merged

rax-cli v1.0.0 #972

merged 4 commits into from
Mar 12, 2019

Conversation

yuanyan
Copy link
Collaborator

@yuanyan yuanyan commented Mar 8, 2019

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@yuanyan yuanyan requested a review from yacheng March 8, 2019 12:55
@yuanyan yuanyan changed the title chore: rax-cli bump v1.0.0 rax-cli v1.0.0 Mar 8, 2019
@weekly-digest weekly-digest bot mentioned this pull request Mar 10, 2019
Closed
@yuanyan yuanyan requested a review from wssgcg1213 March 12, 2019 06:07
wssgcg1213
wssgcg1213 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed,
LGTM, besides 上述引号的问题.

packages/rax-cli/src/generator/miniapp/_eslintrc.js
"es6": true,
"jest": true,
"commonjs": true
'root': true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥在可以去除引号的地方不直接去掉引号呢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

风格保持一致，有些是 "xxx-xxx"

@yuanyan yuanyan merged commit 40be06e into master Mar 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the rax-cli branch March 12, 2019 06:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@yacheng yacheng Awaiting requested review from yacheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanyan @wssgcg1213