Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add youdao translate function #315

Merged
merged 6 commits into from
Jan 13, 2025
Merged

feat: add youdao translate function #315

merged 6 commits into from
Jan 13, 2025

Conversation

Yeaury
Copy link
Contributor

@Yeaury Yeaury commented Dec 25, 2024

Describe what this PR does / why we need it

Youdao Translation's API calls implement the translation service

Does this pull request fix one issue?

#98 #247

Describe how you did it

Describe how to verify it

Special notes for reviews

@Configuration
@ConditionalOnClass(YoudaoTranslateService.class)
@EnableConfigurationProperties(YoudaoTranslateProperties.class)
@ConditionalOnProperty(prefix = "spring.ai.alibaba.functioncalling.youdao", name = "enabled", havingValue = "true")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里命名需要调整为youdaotranslate 对标 microsofttranslate

/**
* @author Yeaury
*/
@ConfigurationProperties(prefix = "spring.ai.alibaba.functioncalling.youdao")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@Yeaury Yeaury requested a review from PolarishT December 28, 2024 01:43
Copy link
Collaborator

@PolarishT PolarishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 24e9d13 into alibaba:main Jan 13, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants