Skip to content

Add methods in imageMatching #730

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 4, 2020
Merged

Add methods in imageMatching #730

merged 10 commits into from
Feb 4, 2020

Conversation

theoleplomb
Copy link

@theoleplomb theoleplomb commented Jan 14, 2020 •
edited
Loading

Description

Add new methods in ImagesMatching to select best candidates for FeatureMatching.
Expose new parameters in FeatureMatching and SfM.

Features list

  • ImageMatching: Implement new Sequential method.
  • ImageMatching: Implement new Frustum intersection method.
  • A new method param allow to choose between:
    -- Sequential: based on filenames order
    -- Vocabulary Tree
    -- Sequential and Vocabulary Tree
    -- Exhaustive
    -- Frustum: when cameras have known poses, compute frustum intersections
  • ImageMatching: Add nbNeighbor param in imageMatching for Sequential method.
  • FeatureMatching: Add matchFromKnownCameraPoses param
  • SfM: Add filterTrackForks param
  • SfM: Add minNbMatches param

@theoleplomb theoleplomb force-pushed the dev/imageMatchingMethods branch 2 times, most recently from e1962ee to ae26081 Compare January 21, 2020 13:28
theoleplomb
theoleplomb commented Jan 23, 2020
View reviewed changes
theoleplomb
theoleplomb commented Jan 23, 2020
View reviewed changes
theoleplomb
theoleplomb commented Jan 23, 2020
View reviewed changes
theoleplomb
theoleplomb commented Jan 23, 2020
View reviewed changes
@theoleplomb theoleplomb force-pushed the dev/imageMatchingMethods branch from 0ac65c8 to a4f3b6e Compare January 24, 2020 09:14
fabiencastan
fabiencastan reviewed Jan 24, 2020
View reviewed changes
fabiencastan
fabiencastan reviewed Jan 24, 2020
View reviewed changes
fabiencastan
fabiencastan reviewed Jan 24, 2020
View reviewed changes
@fabiencastan fabiencastan force-pushed the dev/imageMatchingMethods branch from 0711000 to 326cf4a Compare January 28, 2020 11:48
@theoleplomb theoleplomb mentioned this pull request Jan 30, 2020
Merged
@fabiencastan fabiencastan added this to the 2020.1.0 milestone Jan 30, 2020
fabiencastan
fabiencastan reviewed Jan 30, 2020
View reviewed changes
@fabiencastan
[matching] fixes for feature matches min/max limits
b3e7e56 
Fix minNum/limitNum conditions.
@fabiencastan
[sfm] remove trailing pragma
80a24b8
@fabiencastan
[software] SfM: features/matchesFolders are no more required
b592507 
When computing a SfM node from a previous SfM, the features/matches are
not needed.
@fabiencastan fabiencastan force-pushed the dev/imageMatchingMethods branch from 9cfdc7e to b592507 Compare January 30, 2020 19:47
@fabiencastan fabiencastan merged commit e9476f2 into develop Feb 4, 2020
@fabiencastan fabiencastan deleted the dev/imageMatchingMethods branch February 4, 2020 18:00
@fabiencastan fabiencastan mentioned this pull request Feb 7, 2020
Merged
@natowi natowi mentioned this pull request Mar 13, 2020
Closed
@fabiencastan fabiencastan changed the title Add Methods in imageMatching Add methods in imageMatching Aug 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fabiencastan fabiencastan fabiencastan left review comments

Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@theoleplomb @fabiencastan @simogasp