Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Purge queue in sample rather than testEnded #10

Merged
merged 2 commits into from
May 21, 2022

Conversation

t-h-e
Copy link

@t-h-e t-h-e commented May 9, 2022

testEnded does not work as a new instance of AMQPConsumer is created
and the channel is not set (NullPointerException).
Additionally, the queue should be purged at the point of the test plan
where the consumer is and not when the test plan ended.

`testEnded` does not work as a new instance of AMQPConsumer is created
and the channel is not set (NullPointerException).
Additionally, the queue should be purged at the point of the test plan
where the consumer is and not when the test plan ended.
@sandromario
Copy link

@aliesbelik Could you help us get this reviewed & merged, please (I'm taking over for t-h-e this week)? Apparently the SonarCloud check failed for some reason. Thanks!

Copy link
Owner

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport fix from already merged #11.

@aliesbelik
Copy link
Owner

@sandromario Sorry for delay and thank you for patience.
Sonarcloud failures seem to be irrelevant to changes, will try to investigate (and fix) separately.

@aliesbelik aliesbelik merged commit acec348 into aliesbelik:main May 21, 2022
@aliesbelik
Copy link
Owner

@t-h-e Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants