Eap: Fix check for invaild message hadling #749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
We want to submit some patches that target the EAP message parsing and the handling for authentication. There are three issues that we identified and fixed in this series:
An invalid message type (which leads to a
nullptr
is not handled correctly for the authentication functions (e.g.NasMm::receiveAuthenticationRequestEap
), since the IE might evalute tonullptr
although the message is not valid. This leads to segmentation faults during execution.An EAP message with invalid length fields (a length < 2 for attributes) leads to an unbounded read in
readOctetString
, since thelast
bound is smaller then thefirst
bound.They
enum
type bounds for EAPstructs
are not checked upon parsing, although they provide an early information on processing. This is relevant for parsing the concrete EAPAttributes.We are happy to provide concrete pcap traces if necessary.
Cheers