Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add net8.0 target #65

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Feb 23, 2023

Description

Add net8.0 target

.NET 8 preview 1 published, we need .NET 8.0 support somewhere

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I did test corresponding changes on Windows
  • I did test corresponding changes on Linux
  • I did test corresponding changes on Mac

@alirezanet
Copy link
Owner

Hi @WeihanLi,
Thank you for the PR 💐👌, but isn't it a bit early to support .net8 now? since it is still a preview? I would rather merge this PR after an official release. what do you think?

@WeihanLi
Copy link
Contributor Author

@alirezanet thanks, yeah, it's a little earlier indeed, is it acceptable for a preview release? so that it could be used by those early adopters, and maybe we could prepare for a stable release when .NET 8 RC or GA version released

@alirezanet alirezanet merged commit f6a4d9b into alirezanet:master Feb 26, 2023
@alirezanet
Copy link
Owner

Hi @WeihanLi,
For those who need early access to .net8 I also released a preview version of husky.net, 0.6.0-Preview1.
Thank you for your contribution 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants