Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added environment vars for advanced usage #45

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

besrym
Copy link
Contributor

@besrym besrym commented Mar 23, 2023

these were missing, and this step is not listed in the docs

  • now it agrees with the documentation, which says that only the example.env needs to be configured

  • tested locally: if these vars are not set, docker just throws some warnings:
    image

these were missing, and this step is not listed in the docs
@besrym
Copy link
Contributor Author

besrym commented Mar 24, 2023

or we add this additional configuration step to the docs :)

@jkhenning
Copy link
Member

@besrym I'm not sure I understand - these warnings are usually reported by docker-compose when a variable is references but its value is not provided in environment - why were these mentioned to begin with?

@besrym
Copy link
Contributor Author

besrym commented Mar 27, 2023

@jkhenning yes, exactly but this is not the point here.

The documentation (advanced setup) states that these variables must be set in the examples.env file. But they also need to be placed in the docker-compose.yml and this took me a decent amount of time to figure that out.

@jkhenning
Copy link
Member

Ah, got it now 🙂 👍

@jkhenning jkhenning merged commit 6fb0006 into allegroai:main Mar 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants