Fix to addAgents for proc scenes.
#1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroHG
reviewed
Jun 9, 2022
| } | ||
| this.agents[0].m_Camera.depth = 9999; | ||
| private void addAgents(ServerAction action) { | ||
| if (action.agentCount > 1) { |
There was a problem hiding this comment.
Why do we change it to a non-async function? what impact does this have?
There was a problem hiding this comment.
I think the async functionality was there just to ensure that the transforms' positions/rotations were updated as we do some collision checks in addAgents. I believe this should be solved by using Physics.SyncTransforms() rather than waiting for a frame but let me know if not.
There was a problem hiding this comment.
Ok cool, yeah seems like that was the only purpose to wait till the end of frame this looks good.
|
This makes sense, just a question about the change from an async action. LGTM after that. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that depth of the agent camera is set in nanna houses.