-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Procedural testing #1040
Procedural testing #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review, looks very nice :)! One thing I was expecting but didn't see was more pixel-to-pixel tests within ProcTHOR houses. Is this coming in a different PR?
Ready for merging, LGTM analysis seems to be hanging, but build passed. |
This pull request introduces 18 alerts and fixes 2 when merging 21b5450 into f44c798 - view on LGTM.com new alerts:
fixed alerts:
|
1 similar comment
This pull request introduces 18 alerts and fixes 2 when merging 21b5450 into f44c798 - view on LGTM.com new alerts:
fixed alerts:
|
@AlvaroHG Can you open the LGTM link and double-check the 8 After that, LGTM, please merge. |
This pull request introduces 13 alerts and fixes 2 when merging 593676d into 79e92c5 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 10 alerts and fixes 2 when merging c658efd into 79e92c5 - view on LGTM.com new alerts:
fixed alerts:
|
Merging now, remaining useless assignments are lambda variables that analyzer does not recognize |
New testing layer for Unity using Procedural houses.
Another PR incoming with Rendering tests.
Further improvements and cleanups of templates in the works.