Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removing agentControllerType initialization parameter on nanna branch. #1048

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

Lucaweihs
Copy link
Contributor

Moves #1039 to the nanna branch. Hopefully also fixes the failing tests.

Co-authored-by: Winson Han <winson.whan@gmail.com>
@Lucaweihs Lucaweihs requested review from winthos and mattdeitke July 26, 2022 22:04
@lgtm-com
Copy link

lgtm-com bot commented Jul 26, 2022

This pull request fixes 1 alert when merging ae80ccb into 79e92c5 - view on LGTM.com

fixed alerts:

  • 1 for Use of default ToString()

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request fixes 1 alert when merging 076bed1 into 243aa90 - view on LGTM.com

fixed alerts:

  • 1 for Use of default ToString()

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request fixes 1 alert when merging def80ab into 243aa90 - view on LGTM.com

fixed alerts:

  • 1 for Use of default ToString()

Copy link
Collaborator

@winthos winthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@winthos winthos merged commit 43de4b6 into nanna Jul 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants