Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nanna release api #1062

Merged
merged 40 commits into from
Oct 13, 2022
Merged

Nanna release api #1062

merged 40 commits into from
Oct 13, 2022

Conversation

AlvaroHG
Copy link
Collaborator

  • Big cleanup remove code no longer used, refactor some functions and files
  • Move properties like floorMaterial ceilingMaterial string to encapsulated MaterialProperties allowing easy addition of new support for material and rendering specifications.
  • Deprecates assetOffset in favor of wall relative and center position based assetPosition
  • Deprecates bounding box in doors and windows in favor of polygon (still some mixed feelings about it)
  • Fixes bug for house template transforming correctly array positions to place doors/windows

@AlvaroHG AlvaroHG requested review from mattdeitke and Lucaweihs and removed request for Lucaweihs August 19, 2022 01:49
@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2022

This pull request introduces 6 alerts and fixes 30 when merging 7521fd8 into 7920893 - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable
  • 1 for Dereferenced variable is always null
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 7 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 6 alerts and fixes 30 when merging 4fc5795 into ad56c5b - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable
  • 1 for Dereferenced variable is always null
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 7 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 5 alerts and fixes 30 when merging bc6700a into ad56c5b - view on LGTM.com

new alerts:

  • 3 for Useless assignment to local variable
  • 1 for Dereferenced variable is always null
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 7 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 5 alerts and fixes 30 when merging 670aa6d into 359f7af - view on LGTM.com

new alerts:

  • 3 for Useless assignment to local variable
  • 1 for Dereferenced variable is always null
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 7 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request introduces 10 alerts and fixes 32 when merging 6648c4a into fb408e7 - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable
  • 3 for Use of default ToString()
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 9 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2022

This pull request introduces 10 alerts and fixes 32 when merging cc49eb6 into 2a3a8b4 - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable
  • 3 for Use of default ToString()
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 9 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2022

This pull request introduces 10 alerts and fixes 32 when merging b76282f into 2a3a8b4 - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable
  • 3 for Use of default ToString()
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 17 for Useless assignment to local variable
  • 9 for Use of default ToString()
  • 6 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2022

This pull request introduces 13 alerts and fixes 51 when merging 5285720 into 2a3a8b4 - view on LGTM.com

new alerts:

  • 5 for Use of default ToString()
  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 22 for Use of default ToString()
  • 22 for Useless assignment to local variable
  • 7 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2022

This pull request introduces 13 alerts and fixes 51 when merging 310485b into 250b12c - view on LGTM.com

new alerts:

  • 5 for Use of default ToString()
  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 22 for Use of default ToString()
  • 22 for Useless assignment to local variable
  • 7 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2022

This pull request introduces 13 alerts and fixes 51 when merging 886116c into 250b12c - view on LGTM.com

new alerts:

  • 5 for Use of default ToString()
  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 22 for Use of default ToString()
  • 22 for Useless assignment to local variable
  • 7 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2022

This pull request introduces 13 alerts and fixes 51 when merging cbdb065 into 250b12c - view on LGTM.com

new alerts:

  • 5 for Use of default ToString()
  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 22 for Use of default ToString()
  • 22 for Useless assignment to local variable
  • 7 for Dereferenced variable may be null

1 similar comment
@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2022

This pull request introduces 13 alerts and fixes 51 when merging cbdb065 into 250b12c - view on LGTM.com

new alerts:

  • 5 for Use of default ToString()
  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 22 for Use of default ToString()
  • 22 for Useless assignment to local variable
  • 7 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2022

This pull request introduces 13 alerts and fixes 51 when merging 51871f8 into 250b12c - view on LGTM.com

new alerts:

  • 5 for Use of default ToString()
  • 5 for Useless assignment to local variable
  • 2 for Dereferenced variable may be null
  • 1 for Dereferenced variable is always null

fixed alerts:

  • 22 for Use of default ToString()
  • 22 for Useless assignment to local variable
  • 7 for Dereferenced variable may be null

@AlvaroHG AlvaroHG merged commit c9833a5 into nanna Oct 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants