feat: erc2098 signature representation #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/erc2098
branch
from
b9a75c2 to
f12e0df
Compare
mattsse
reviewed
Feb 14, 2025
klkvr
reviewed
Feb 15, 2025
onbjerg
force-pushed
the
onbjerg/erc2098
branch
from
f12e0df to
8229e53
Compare
onbjerg
force-pushed
the
onbjerg/erc2098
branch
from
8229e53 to
e6e0f30
Compare
klkvr
approved these changes
Feb 25, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This representation of the signature is slightly more compact and can be useful for on-chain signature verification as it saves calldata.
Closes #873
Solution
Add a helper to generate such a representation
PR Checklist