You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AllureReportServlet.doGet() triggers a MalformedURLException resulting in a blank page when viewing the "Allure Report" tab in Bamboo.
AllureArtifactsManager.getLocalStorageURL() assumes that a file path can be converted to a URL using String.format("file://%s", fullPath) and fails to produce a valid URL on Windows. File.toURI().toURL() should be used instead.
AllureReportServlet.setResponseHeaders() also incorrectly handles conversions from fileUrl to a Path. Instead of using Paths.get(new URL(fileUrl).getPath)) which breaks on Windows, Paths.get(new URL(fileUrl).toURI()) can be used instead.
The URL/URI conversions introduce some ugly exceptions. I'll provide a PR with some rudimentary exception handling shortly.
The text was updated successfully, but these errors were encountered:
bmsq
added a commit
to bmsq/allure-bamboo
that referenced
this issue
Jun 12, 2018
AllureReportServlet.doGet() triggers a MalformedURLException resulting in a blank page when viewing the "Allure Report" tab in Bamboo.
AllureArtifactsManager.getLocalStorageURL() assumes that a file path can be converted to a URL using
String.format("file://%s", fullPath)
and fails to produce a valid URL on Windows.File.toURI().toURL()
should be used instead.AllureReportServlet.setResponseHeaders() also incorrectly handles conversions from
fileUrl
to aPath
. Instead of usingPaths.get(new URL(fileUrl).getPath))
which breaks on Windows,Paths.get(new URL(fileUrl).toURI())
can be used instead.The URL/URI conversions introduce some ugly exceptions. I'll provide a PR with some rudimentary exception handling shortly.
The text was updated successfully, but these errors were encountered: