Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix download url discrepancy. #61

Merged

Conversation

krmahadevan
Copy link
Contributor

After 2.7.0 it looks like the following has changed

  1. The standalone binary name has changed from
    “allure” to “allure-commandline”

This changes captures the change in the standalone
binary name and also accommodates the url suffix
pattern for the newer version downloads.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2019

CLA assistant check
All committers have signed the CLA.

@krmahadevan
Copy link
Contributor Author

ping @baev - Please help take a look and merge

After 2.7.0 it looks like the following has changed

1. The standalone binary name has changed from 
“allure” to “allure-commandline”

This changes captures the change in the standalone
binary name and also accommodates the url suffix
pattern for the newer version downloads.
@krmahadevan krmahadevan force-pushed the fix-download-url-discrepancy branch from 15e4282 to a10bbbe Compare July 27, 2019 09:33
@krmahadevan
Copy link
Contributor Author

@baev - Is there anything pending from my side, before this can be merged?

@baev baev merged commit 2255734 into allure-framework:master Jul 28, 2019
@krmahadevan krmahadevan deleted the fix-download-url-discrepancy branch July 28, 2019 13:46
@krmahadevan
Copy link
Contributor Author

@baev - Thanks for helping with the merge. Considering the fact that without this change-set its not possible to use the latest released version of allure plugin (2.12.1) in Bamboo because the generated report is all skewed up because Bamboo plugin ends up downloading 2.7.0 version of the standalone (which used to be called as allure.zip), can you please let me know if there are plans on releasing another version of the bamboo plugin ?

Right now, I have had to apply this fix locally, build a jar and coax my devops team to install this offline plugin instead of grabbing the plugin from the marketplace.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants