Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename remaining names to Alma Career #392

Open
4 of 5 tasks
OndraM opened this issue Dec 19, 2024 · 5 comments
Open
4 of 5 tasks

Rename remaining names to Alma Career #392

OndraM opened this issue Dec 19, 2024 · 5 comments
Milestone

Comments

@OndraM
Copy link
Member

OndraM commented Dec 19, 2024

All functions, types and files should be renamed:

  • initLmcCookieConsentManager -> initAlmaCareerCookieConsentManager
  • LmcCookieConsentManager -> CookieConsentManager/AlmaCareerCookieConsentManager
  • LmcCookieConsentManager.ts -> CookieConsentManager.ts
  • LmcCookieConsentManager.scss -> CookieConsentManager.scss
  • CSS variables (--lmcccm -> --ccm/--acccm/...?)
@literat

This comment was marked as outdated.

@OndraM

This comment was marked as off-topic.

@OndraM
Copy link
Member Author

OndraM commented Jan 10, 2025

@literat @adamkudrna What new prefix (without the LMC part) for the css properties would you suggest?

Currently the naming scheme is --lmcccm-font-family, --lmcccm-bg, ...

So just remove the lmc part, making it --ccm-font-family, --ccm-bg, ...?

@literat
Copy link
Contributor

literat commented Jan 10, 2025

So just remove the lmc part, making it --ccm-font-family, --ccm-bg, ...?

I am fine with this.

@adamkudrna
Copy link
Member

So just remove the lmc part, making it --ccm-font-family, --ccm-bg, ...?

I am fine with this.

Why not. I was also thinking about alma (--alma-font-family) so the company name would be included. But I'm OK with ccm, no strong opinion.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants