Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BREAKING CHANGE: Rename settingsModalMoreInfo to preferencesModalMoreInfo #396

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

OndraM
Copy link
Member

@OndraM OndraM commented Jan 2, 2025

In CC 3.0 "settings modal" is now everywhere called "preferences modal".

To make it consistent also in translationOverrides, we change settingsModalMoreInfo option to preferencesModalMoreInfo and also rename the relateD scss file.

@OndraM OndraM requested a review from literat as a code owner January 2, 2025 11:56
@github-actions github-actions bot added the BC Breaking change label Jan 2, 2025
@OndraM OndraM force-pushed the bc/settings-to-preferences branch from 67a6537 to 46f2c3a Compare January 2, 2025 12:01
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cookie-consent-manager ready!

Name Link
🔨 Latest commit 67a6537
🔍 Latest deploy log https://app.netlify.com/sites/cookie-consent-manager/deploys/67767ed37158020008aa54af
😎 Deploy Preview https://deploy-preview-396--cookie-consent-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for cookie-consent-manager ready!

Name Link
🔨 Latest commit 5f5fd64
🔍 Latest deploy log https://app.netlify.com/sites/cookie-consent-manager/deploys/6776aace415fe6000874a62a
😎 Deploy Preview https://deploy-preview-396--cookie-consent-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OndraM OndraM force-pushed the bc/settings-to-preferences branch from 46f2c3a to 5f5fd64 Compare January 2, 2025 15:03
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is hard...

@OndraM OndraM merged commit 3ed682d into release/v3 Jan 6, 2025
12 checks passed
@OndraM OndraM deleted the bc/settings-to-preferences branch January 6, 2025 11:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
BC Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants