Fixing asterisk for prime #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aloe-earn ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for aloe-blend-staging canceled.
|
✅ Deploy Preview for aloe-prime ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
haydenshively
approved these changes
Oct 20, 2022
haydenshively
added a commit
that referenced
this pull request
Nov 7, 2022
* Factoring out components that import tw macro (#97) * Adding pre-commit, fixing linting issues (#105) * Moving lending pair logic to lending pair. Fixing small bugs. (#102) * Add auto refresh when user acks successful modal (#106) * Adding logic to update the liquidation threshold (#108) * Refactoring create margin account flow (#110) * Factoring out Components, Stage 2 (#111) * Adding gradient border and shadow to margin account card on hover (#121) * Fixing font weight of range stepper input (#122) * Updating ESLint (#120) Co-authored-by: Hayden Shively <17186559+haydenshively@users.noreply.github.com> * Fixing asterisk for prime (#124) * Adding uniswap position tables (#126) Co-authored-by: Hayden Shively <17186559+haydenshively@users.noreply.github.com> * Additional linting for objects on single line (#128) * Version 1 of a claim fees action card for uniswap positions (#127) * Update Remove Liquidity Action description Co-authored-by: Hayden Shively <17186559+haydenshively@users.noreply.github.com> * Adding placeholder for lend pie chart (#117) Co-authored-by: Hayden Shively <17186559+haydenshively@users.noreply.github.com> * Move action-related logic + data models to their own folder (#131) * Remove amounts from Uniswap Position data structure (#133) * Restore ActionCard state purely from fields (#136) * Make UI aware of whether user has already claimed fees for a Uni pos (#141) * Polish various UI/UX stuff (#147) Co-authored-by: Ian Woodard <ianwoodard2000@gmail.com> * Doing some post-refactor cleanup (#152) Co-authored-by: Hayden Shively <17186559+haydenshively@users.noreply.github.com> Co-authored-by: Aneesh Atri <aneesh.atri@gmail.com> Co-authored-by: Ian Woodard <17186604+IanWoodard@users.noreply.github.com> Co-authored-by: Ian Woodard <ianwoodard2000@gmail.com>
haydenshively
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Fixing asterisk when no actions are present * linting
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123
Previously we did not check and subsequently remove the asterisk if the user removed all of their actions, which would mean they cannot be viewing a hypothetical state, and thus we shouldn't show the asterisk.