-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add operator closures to every ActionCard #135
Conversation
c4157dc
to
e22f884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments, still reviewing the core code.
prime/src/components/borrow/actions/AloeMintTokenPlusActionCard.tsx
Outdated
Show resolved
Hide resolved
prime/src/components/borrow/actions/AloeBurnTokenPlusActionCard.tsx
Outdated
Show resolved
Hide resolved
prime/src/components/borrow/actions/AloeAddMarginActionCard.tsx
Outdated
Show resolved
Hide resolved
e22f884
to
ebfa5bd
Compare
✅ Deploy Preview for aloe-blend-staging canceled.
|
✅ Deploy Preview for aloe-prime ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for aloe-earn canceled.
|
d603015
to
e3ba859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, but otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds on top of #134. Adds
operator
as something that every ActionCard returns. A future PR will use theseoperator
s to compute hypothetical state instead of the deltas (AloeResult
andUniswapResult
), at which point we can delete those.