Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add operator closures to every ActionCard #135

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Conversation

haydenshively
Copy link
Member

@haydenshively haydenshively commented Oct 25, 2022

Builds on top of #134. Adds operator as something that every ActionCard returns. A future PR will use these operators to compute hypothetical state instead of the deltas (AloeResult and UniswapResult), at which point we can delete those.

@haydenshively haydenshively changed the title Hs operators Add operator closures to every ActionCard Oct 25, 2022
Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments, still reviewing the core code.

Base automatically changed from hs-clean-uniswap-actions2 to master October 26, 2022 18:49
@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for aloe-blend-staging canceled.

Name Link
🔨 Latest commit e3ba859
🔍 Latest deploy log https://app.netlify.com/sites/aloe-blend-staging/deploys/6359822084118b0008dc0e17

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for aloe-prime ready!

Name Link
🔨 Latest commit e3ba859
🔍 Latest deploy log https://app.netlify.com/sites/aloe-prime/deploys/6359822093fe7b00081b88d1
😎 Deploy Preview https://deploy-preview-135--aloe-prime.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for aloe-earn canceled.

Name Link
🔨 Latest commit e3ba859
🔍 Latest deploy log https://app.netlify.com/sites/aloe-earn/deploys/63598220ec9db50009e2a973

Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but otherwise, LGTM

@IanWoodard IanWoodard self-requested a review October 27, 2022 16:12
Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haydenshively haydenshively merged commit 0735694 into master Oct 27, 2022
@haydenshively haydenshively deleted the hs-operators branch October 27, 2022 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants