Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Expand timeframe options for getbars #89

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Expand timeframe options for getbars #89

merged 4 commits into from
Jan 12, 2022

Conversation

jerrami
Copy link
Contributor

@jerrami jerrami commented Jan 12, 2022

  • Added specific union types for GetBarsV1 and GetBarsV2 timeframes.
  • Added both as exports from index.ts so that other developers can specify their own for example with timeframe: '20Min' as BarsTimeframe as opposed to having to specify full union type match, or unknown or any.
  • Also specified timeframe values for PortfolioHistory calls based on Portfolio History and REST testing.

Let me know if you have any questions or feedback. And thanks again for sharing this with the community. -Jerrami

@117
Copy link
Contributor

117 commented Jan 12, 2022

Will merge and publish tmrw!

@117 117 linked an issue Jan 12, 2022 that may be closed by this pull request
Expand timeframe options for getBars #88
Closed
@117 117 merged commit 049f7f6 into alpacahq:main Jan 12, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@117 117 117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand timeframe options for getBars
2 participants
@jerrami @117