Skip to content

Commit

Permalink
Merge pull request #41 from SimeonEhrig/supportCUDA12.3
Browse files Browse the repository at this point in the history
support CUDA 12.3
  • Loading branch information
SimeonEhrig authored Jan 4, 2024
2 parents 9d72e66 + 82aa13f commit 7cc991a
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
3 changes: 2 additions & 1 deletion src/alpaka_job_coverage/filter_compiler_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def compiler_version_filter(
# a new gcc version the first time
# the latest CUDA SDK, also if it supports no new gcc version
# (maximum_CUDA_SDK_version, "maximum_gcc_version")
("12.2", "12"),
("12.3", "12"),
("12.0", "12"),
("11.4", "11"),
("11.1", "10"),
Expand Down Expand Up @@ -151,6 +151,7 @@ def compiler_version_filter(
# a new clang version the first time
# the latest CUDA SDK, also if it supports no new clang version
# (maximum_CUDA_SDK_version, "maximum_clang_version")
("12.3", "16"),
("12.2", "15"),
("12.1", "15"),
("12.0", "14"),
Expand Down
2 changes: 1 addition & 1 deletion src/alpaka_job_coverage/filter_software_dependency.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def software_dependency_filter(
nvcc_cxx_versions = [
("11.0", 17), # NVCC versions older than 11.0 does not support C++ 17
("12.0", 20), # NVCC versions older than 12.0 does not support C++ 20
("12.3", 23), # NVCC 12.3 is not released yet, therefore we need to
("12.4", 23), # NVCC 12.3 is not released yet, therefore we need to
# expect that it could support C++23
]
for nvcc_version, cxx_version in nvcc_cxx_versions:
Expand Down
1 change: 1 addition & 0 deletions src/alpaka_job_coverage/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"12.0",
"12.1",
"12.2",
"12.3",
],
HIPCC: ["5.0", "5.1", "5.2", "5.3", "5.4", "5.5", "5.6", "5.7", "6.0"],
ICPX: ["2023.1.0", "2023.2.0"],
Expand Down
14 changes: 9 additions & 5 deletions tests/test_cuda_sdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def test_if_backend_is_disabled(self):

def test_backend_versions(self):
# for NVCC, the compiler version needs to be equal to the backend version
for version in ["10.2", "11.0", "12.2"]:
for version in ["10.2", "11.0", "12.3"]:
comb1 = [
(GCC, "9"),
(NVCC, version),
Expand Down Expand Up @@ -256,7 +256,7 @@ def test_backend_versions(self):
for nvcc_version, backend_version in [
("10.1", "10.2"),
("11.0", "11.5"),
("11.8", "12.2"),
("11.8", "12.3"),
]:
comb1 = [
(GCC, "9"),
Expand Down Expand Up @@ -389,6 +389,8 @@ def test_known_version(self):
("12.1", "13", False),
("12.2", "12", True),
("12.2", "13", False),
("12.3", "12", True),
("12.3", "13", False),
]

for nvcc_version, gcc_version, expected_value in expected_results:
Expand Down Expand Up @@ -471,6 +473,8 @@ def test_known_version(self):
("12.1", "16", False),
("12.2", "15", True),
("12.2", "16", False),
("12.3", "16", True),
("12.3", "17", False),
]

for nvcc_version, clang_version, expected_value in expected_results:
Expand Down Expand Up @@ -525,17 +529,17 @@ def setDown(self):
# If SDK version is unknown, all C++ standards should be allowed.
def test_nvcc_cxx(self):
# verify that our test version are not supported
manual_version_test(self, NVCC, [], ["12.2, 45.0"])
manual_version_test(self, NVCC, [], ["12.3, 45.0"])

for nvcc_version, max_cxx in [
("11.0", 17),
("11.2", 17),
("11.8", 17),
("12.0", 20),
("12.2", 20),
("12.3", 20),
# not released version
# therefore they should support all C++ versions
("12.3", 32),
("12.4", 32),
("45.0", 32),
]:
for cxx_version in [11, 14, 17, 20, 23, 26, 29, 32]:
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.5.7
1.5.8

0 comments on commit 7cc991a

Please # to comment.