Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Include hidden status of the component examples in published fixtures #2031

Merged
merged 3 commits into from
Dec 16, 2020
Merged

Include hidden status of the component examples in published fixtures #2031

merged 3 commits into from
Dec 16, 2020

Commits on Dec 15, 2020

  1. Expose hidden status of component examples in packaged fixtures 

    In order for downstream projects to use the component examples for
rendering as well as for tests, it is useful to know which examples
should be hidden from display since they were designed for tests only.
    @andymantell @36degrees
    andymantell authored and 36degrees committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    a8a3dcd View commit details
    Browse the repository at this point in the history

  2. Add changelog entry for exposing hidden states of components in fixtures 

    See a59a66c
    @andymantell @36degrees
    andymantell authored and 36degrees committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    77ff06e View commit details
    Browse the repository at this point in the history

  3. Update package tests to check for hidden attribute 

    Remove the outer `expect.objectContaining` so that any additional top level keys in the fixture object cause the tests to fail.

Co-erce the hidden attribute to a boolean to ensure it’s always present, rather than only being present when it’s set in the YAML.
    @36degrees
    36degrees committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    49ad231 View commit details
    Browse the repository at this point in the history