Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PATCH 0/7] samples: add Python 3 asynchronous runtime sample and delete GUI samples #105

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

takaswie
Copy link
Member

@takaswie takaswie commented Sep 25, 2024

Hi,

In recent years, asynchronous programming model becomes major in some languages.

This series of changes adds a sample script for Python 3 asynchronous runtime. But some GUI samples are deleted since the speed of integration in GTK/QT GUI toolkit project is faster than this project and sometimes hard to follow. Consequently, the sample scripts to read quadlet data remain in this repository.

Takashi Sakamoto (7):
  fw_req: fix annotation for Hinawa.FwReqError.quark()
  meson: fix comment addressing to sound subsystem
  samples: add a Python 3 script to read quadlet data with blocking API
  samples: add a Python 3 script to read quadlet data with asynchronous
    runtime
  samples: delete GUI samples
  samples: format sample script
  ci: delete gi-docgen package in each repository

 .github/workflows/build.yml |  26 ----
 meson.build                 |   2 +-
 samples/common/__init__.py  | 263 +++++-------------------------------
 samples/gtk3                |  91 -------------
 samples/gtk4                |  95 -------------
 samples/qt5                 | 116 ----------------
 samples/read-quadlet        | 110 +++++++++++++++
 samples/read-quadlet-async  | 204 ++++++++++++++++++++++++++++
 src/fw_req.c                |   2 +-
 9 files changed, 349 insertions(+), 560 deletions(-)
 delete mode 100755 samples/gtk3
 delete mode 100755 samples/gtk4
 delete mode 100755 samples/qt5
 create mode 100755 samples/read-quadlet
 create mode 100755 samples/read-quadlet-async

@takaswie takaswie requested a review from a team September 25, 2024 10:59
@takaswie takaswie self-assigned this Sep 25, 2024
@takaswie takaswie changed the title samples: add Python 3 asynchronous runtime sample and delete GUI samples [PATCH 0/6] samples: add Python 3 asynchronous runtime sample and delete GUI samples Sep 25, 2024
@takaswie takaswie force-pushed the topic/delete-gui-samples branch from b8f5b18 to 25eba6a Compare September 25, 2024 11:02
@takaswie takaswie changed the title [PATCH 0/6] samples: add Python 3 asynchronous runtime sample and delete GUI samples [PATCH 0/7] samples: add Python 3 asynchronous runtime sample and delete GUI samples Sep 25, 2024
@takaswie takaswie force-pushed the topic/delete-gui-samples branch from 97c3d11 to a8192f9 Compare September 26, 2024 12:58
It is specific to Hinawa.FwReqError, not to Hinawa.FwRcode.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
It is wrong.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
As a basic demonstration.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
… runtime

As a demonstration by asynchronous programming model.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
The progress of GUI toolkit development is so fast, while I would like to
keep the integration of libhinawa so small.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
By ruff formatter.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
As of a commit 3c3d9b6 ("doc: annotate error domain available in
gi-docgen 2023.1"), the version of gi-docgen package in each respository
includes some bugs to generate error domain. Nowadays it is solved.

This commit deletes the workaround in github workflow.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
@takaswie takaswie force-pushed the topic/delete-gui-samples branch from a8192f9 to cdf020b Compare September 26, 2024 13:00
@takaswie takaswie merged commit de0cdbd into master Sep 28, 2024
4 checks passed
@takaswie takaswie deleted the topic/delete-gui-samples branch September 28, 2024 01:02
@takaswie
Copy link
Member Author

Merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant