linters #9
Merged
linters #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alvinjohnsonso
commented
Dec 13, 2021
alvinjohnsonso
commented
- Added linters
- CSS - stylelint
- JS - eslint
- PHP - phpcs
- Added pre-commit hook for linting
- Resolved issues reported by the linters
alvinjohnsonso
commented
Dec 13, 2021
| '*.css': 'stylelint --cache --fix', | ||
| '*.php': [ | ||
| 'composer run lint:fix', | ||
| 'composer run lint' |
There was a problem hiding this comment.
In case anyone asks, the commands that were use in these scripts came from only one package which is PHPCS.
Basically, the command composer run lint uses phpcs which is the linter and composer run lint:fix uses phpcbf which is the fixer that was included in the PHPCS package.
alvinjohnsonso
commented
Dec 13, 2021
| "scripts": { | ||
| "post-install-cmd": "phpcs --config-set installed_paths vendor/wp-coding-standards/wpcs,vendor/phpcompatibility/php-compatibility", | ||
| "lint": "phpcs -p -s -v --runtime-set ignore_warnings_on_exit true tawkto", | ||
| "lint:fix": "phpcbf -p -s -v tawkto; err=$?; if [ $err -eq 1 ]; then exit 0; else exit $err; fi;" |
There was a problem hiding this comment.
Made a custom handler for exit code for the command phpcbf because, according to this comment in one of the issues reported to PHPCS, here are the current exit codes for phpcbf:
- Exit code 0 is used to indicate that no errors were found
- Exit code 1 is used to indicate that errors were found but can be fixed
- Exit code 2 is used to indicate that errors were found and some can be fixed
So I made a handler for exit code 1 to have an exit code of 0 just so lint-staged won't fail.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.