fix(packets): 🐛 Fix negotiation packet parsing; fixes protocol break #3748
clippy
20 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 20 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956e 2024-04-29)
Annotations
Check warning on line 60 in alvr\dashboard\src\dashboard\components\settings_controls\text.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> alvr\dashboard\src\dashboard\components\settings_controls\text.rs:60:21
|
60 | *text_mut = editing_value_mut.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `text_mut.clone_from(&editing_value_mut)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 326 in alvr\client_openxr\src\lib.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> alvr\client_openxr\src\lib.rs:326:25
|
326 | last_lobby_message = message.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `last_lobby_message.clone_from(&message)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> alvr\dashboard\src\dashboard\components\settings_controls\presets\higher_order_choice.rs:129:13
|
129 | selected_option = key.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `selected_option.clone_from(key)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 152 in alvr\dashboard\src\dashboard\components\settings_controls\dictionary.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> alvr\dashboard\src\dashboard\components\settings_controls\dictionary.rs:152:33
|
152 | ... *text_mut = editing_key_mut.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `text_mut.clone_from(&editing_key_mut)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 158 in alvr\dashboard\src\dashboard\components\settings_controls\choice.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> alvr\dashboard\src\dashboard\components\settings_controls\choice.rs:158:21
|
158 | *variant_mut = self.variant_labels[index].id.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `variant_mut.clone_from(&self.variant_labels[index].id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 136 in alvr\dashboard\src\dashboard\components\settings_controls\choice.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> alvr\dashboard\src\dashboard\components\settings_controls\choice.rs:136:21
|
136 | *variant_mut = self.variant_labels[index].id.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `variant_mut.clone_from(&self.variant_labels[index].id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 182 in alvr\client_openxr\src\lib.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> alvr\client_openxr\src\lib.rs:182:9
|
182 | let mut stream_config = None::<StreamConfig>;
| ----^^^^^^^^^^^^^
| |
| help: remove this `mut`
Check warning on line 181 in alvr\client_openxr\src\lib.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> alvr\client_openxr\src\lib.rs:181:9
|
181 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 326 in alvr\client_openxr\src\lib.rs
github-actions / clippy
value assigned to `last_lobby_message` is never read
warning: value assigned to `last_lobby_message` is never read
--> alvr\client_openxr\src\lib.rs:326:25
|
326 | last_lobby_message = message.clone();
| ^^^^^^^^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` on by default
Check warning on line 194 in alvr\client_openxr\src\lib.rs
github-actions / clippy
unused variable: `xr_frame_stream`
warning: unused variable: `xr_frame_stream`
--> alvr\client_openxr\src\lib.rs:194:51
|
194 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
Check warning on line 194 in alvr\client_openxr\src\lib.rs
github-actions / clippy
unused variable: `xr_frame_waiter`
warning: unused variable: `xr_frame_waiter`
--> alvr\client_openxr\src\lib.rs:194:30
|
194 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
Check warning on line 194 in alvr\client_openxr\src\lib.rs
github-actions / clippy
unused variable: `xr_session`
warning: unused variable: `xr_session`
--> alvr\client_openxr\src\lib.rs:194:14
|
194 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
Check warning on line 182 in alvr\client_openxr\src\lib.rs
github-actions / clippy
unused variable: `stream_config`
warning: unused variable: `stream_config`
--> alvr\client_openxr\src\lib.rs:182:13
|
182 | let mut stream_config = None::<StreamConfig>;
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`
Check warning on line 181 in alvr\client_openxr\src\lib.rs
github-actions / clippy
unused variable: `last_lobby_message`
warning: unused variable: `last_lobby_message`
--> alvr\client_openxr\src\lib.rs:181:13
|
181 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 200 in alvr\client_openxr\src\lib.rs
github-actions / clippy
unreachable definition
warning: unreachable definition
--> alvr\client_openxr\src\lib.rs:200:13
|
196 | .create_session(xr_system, &egl_context.session_create_info())
| --------------------------------- any code following this expression is unreachable
...
200 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr\client_openxr\src\lib.rs:196:45
|
196 | .create_session(xr_system, &egl_context.session_create_info())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
Check warning on line 8 in alvr\dashboard\src\dashboard\components\settings_controls\notice.rs
github-actions / clippy
function `notice` is never used
warning: function `notice` is never used
--> alvr\dashboard\src\dashboard\components\settings_controls\notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 26 in alvr\xtask\src\packaging.rs
github-actions / clippy
assigning the result of `ToOwned::to_owned()` may be inefficient
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> alvr\xtask\src\packaging.rs:26:9
|
26 | version = version[..idx].to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `version[..idx].clone_into(&mut version)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 23 in alvr\xtask\src\packaging.rs
github-actions / clippy
assigning the result of `ToOwned::to_owned()` may be inefficient
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> alvr\xtask\src\packaging.rs:23:9
|
23 | version = version[..idx].to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `version[..idx].clone_into(&mut version)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 12 in alvr\xtask\src\packaging.rs
github-actions / clippy
function `build_windows_installer` is never used
warning: function `build_windows_installer` is never used
--> alvr\xtask\src\packaging.rs:12:4
|
12 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 50 in alvr\common\src\logging.rs
github-actions / clippy
unused variable: `short_err_str`
warning: unused variable: `short_err_str`
--> alvr\common\src\logging.rs:50:13
|
50 | let short_err_str = panic_info.to_string();
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_short_err_str`
|
= note: `#[warn(unused_variables)]` on by default