ADO - 36952 Update to rails above 5.0 #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenbeuken
requested changes
Jun 13, 2023
ama_styles.gemspec
Outdated
| @@ -44,10 +44,10 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'dotenv-rails' | |||
| s.add_dependency 'font-awesome-sass', '>= 5.0.6' | |||
| s.add_dependency 'foundation-rails', '~> 6.4.3.0' | |||
| s.add_dependency 'rails', '~> 5.0' | |||
| s.add_dependency 'rails', '~> 6' | |||
There was a problem hiding this comment.
so that it's backwards compatible, how about '>= 5.0'?
ama_styles.gemspec
Outdated
| s.add_dependency 'redis-rails' | ||
| s.add_dependency 'sass-rails' | ||
| s.add_dependency 'sprockets', '~> 3.7' | ||
| s.add_dependency 'sprockets', '~> 4.0' |
There was a problem hiding this comment.
so that it's backwards compatible, how about '>= 4.0'?
darkodosenovic
changed the title
mvandenbeuken
previously approved these changes
Jun 13, 2023
darkodosenovic
force-pushed
the
update-rails-6
branch
from
6c0ee27 to
860c124
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐘
Update rails to any above 5.0
Update sprockets to any above 4.0
AB#36952