Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix building with JDK 16 #247

Closed
Thihup opened this issue May 31, 2021 · 1 comment
Closed

Fix building with JDK 16 #247

Thihup opened this issue May 31, 2021 · 1 comment
Milestone
0.8.0

Comments

@Thihup
Copy link

Thihup commented May 31, 2021

In JDK 13, the option --no-module-directories was removed from Javadoc, so building with a current JDK, fails the build with
Exit code: 1 - javadoc: error - invalid flag: --no-module-directories.

More info: https://bugs.openjdk.java.net/browse/JDK-8215582
amaembo added a commit that referenced this issue Nov 5, 2021
@amaembo
[#246] Add module-info to the project
b7b5181 
Also fixes [#247] Fix building with JDK 16
@amaembo amaembo added this to the 0.8.0 milestone Nov 5, 2021
amaembo added a commit that referenced this issue Nov 5, 2021
@amaembo
[#246] Add module-info to the project
d5d57c2 
Also fixes [#247] Fix building with JDK 16
@amaembo amaembo closed this as completed Nov 5, 2021
@amaembo
Copy link
Owner

amaembo commented Nov 5, 2021

I updated pom.xml to avoid this option and tested that it's possible to build using Java 17. Still, reference builds are created using Java 11.

@virustotalop virustotalop mentioned this issue May 17, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@amaembo @Thihup