Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue 185 - add EntryStream.withoutKeys() and `EntryStream.withoutValues #233

Conversation

born-to-be-mad
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.634% when pulling 64e94f3 on dma1979:issue/#185-withoutKeys-and-withoutValues into 631cd5a on amaembo:master.

@amaembo
Copy link
Owner

amaembo commented Sep 19, 2020

The idea of withoutKeys() and withoutValues() requested in #185 is filtering, not mapping. It's removing entries that have a specified key or value. See StreamEx#without. Your withoutKeys() method is analogous to existing values() method and withoutValues() is analogous to existing keys() method, so this is completely redundant. Unfortunately, I have to decline this pull-request. If you like, you can implement the actually desired feature as a separate pull-request.

@amaembo amaembo closed this Sep 19, 2020
@born-to-be-mad born-to-be-mad deleted the issue/#185-withoutKeys-and-withoutValues branch January 16, 2021 16:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants