fix: correct integrating with clerk #1754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. change `protect` usage to latest version 2. add locale prefix matcher and non locale prefix matcher at the same time to avoid infinite redirect
amannn
reviewed
Feb 28, 2025
| @@ -263,10 +263,10 @@ import {routing} from './i18n/routing'; | |||
|
|
|||
| const handleI18nRouting = createMiddleware(routing); | |||
|
|
|||
| const isProtectedRoute = createRouteMatcher(['/:locale/dashboard(.*)']); | |||
| const isProtectedRoute = createRouteMatcher(['/dashboard(.*)', '/:locale/dashboard(.*)']); | |||
There was a problem hiding this comment.
Can you explain why this is necessary? The example currently is based on localePrefix: 'always' since it's the default. Why is there a necessity to match /dashboard/…?
| export default clerkMiddleware((auth, req) => { | ||
| if (isProtectedRoute(req)) auth().protect(); | ||
| export default clerkMiddleware(async (auth, req) => { | ||
| if (isProtectedRoute(req)) await auth.protect(); |
There was a problem hiding this comment.
Can you upgrade the version number below the snippet?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protectusage to latest versionFixes #1458