Memory Optimizations for ErrorOr<TValue> #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new class called 'KnownErrors' which contains the NoFirstError and NoErrors instances that previously resided in ErrorOr<TValue>. With this change, they will not reside in memory several times during runtime (once for each type TValue is resolved to). Furthermore, I cached two lists so that they won't be instantiated every time the Errors and ErrorsOrEmptyList property is called. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
|
Why not having |
|
Because a struct cannot be declared with the |
Oh okay nice one, and can't have a singleton tho for the same reason :) |
zbyszekprasak
added a commit
to zbyszekprasak/error-or
that referenced
this pull request
Dec 3, 2024
zbyszekprasak
added a commit
to zbyszekprasak/error-or
that referenced
this pull request
Dec 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #98 and introduces a new class called 'KnownErrors' which contains the NoFirstError and NoErrors instances that previously resided in
ErrorOr<TValue>. With this change, they will not reside in memory several times during runtime (once for each typeTValueis resolved to). Furthermore, I cached two lists so that they won't be instantiated every time theErrorsandErrorsOrEmptyListproperty is called.