deprecation: Ankaa-2 #1060
Merged
deprecation: Ankaa-2 #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 135 135
Lines 9085 9085
Branches 1045 1045
=========================================
Hits 9085 9085 ☔ View full report in Codecov by Sentry. |
rmshaffer
approved these changes
Feb 8, 2025
| @@ -50,7 +50,7 @@ class _Rigetti(str, Enum): | |||
| _AspenM1 = "arn:aws:braket:us-west-1::device/qpu/rigetti/Aspen-M-1" | |||
| _AspenM2 = "arn:aws:braket:us-west-1::device/qpu/rigetti/Aspen-M-2" | |||
| _AspenM3 = "arn:aws:braket:us-west-1::device/qpu/rigetti/Aspen-M-3" | |||
| Ankaa2 = "arn:aws:braket:us-west-1::device/qpu/rigetti/Ankaa-2" | |||
| _Ankaa2 = "arn:aws:braket:us-west-1::device/qpu/rigetti/Ankaa-2" | |||
There was a problem hiding this comment.
Will this break tests for notebooks that are still referencing Ankaa-2?
There was a problem hiding this comment.
Only if the pinned SDK version is updated; we can bump up the version in the notebooks after we make the corresponding changes there.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Also made integ tests more robust to device retirement
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.