Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add more tests for code gen subcommand #7

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add more tests for code gen subcommand #7

merged 1 commit into from
Jun 6, 2024

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Jun 6, 2024

Issue #, if available:

Description of changes:

This PR adds more tests for code gen subcommand generate.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@desaikd desaikd mentioned this pull request Jun 6, 2024
Merged
@desaikd desaikd requested a review from popematt June 6, 2024 00:16
popematt
popematt approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but it also makes me think that perhaps we should have a GHA workflow for this that exercises installing it.

@desaikd desaikd mentioned this pull request Jun 6, 2024
Open
@desaikd desaikd merged commit bf3e5d7 into main Jun 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@popematt popematt popematt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desaikd @popematt