Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#147: improve the get cache function to handle errors #148

Merged
merged 2 commits into from
Dec 17, 2018
Merged

#147: improve the get cache function to handle errors #148

merged 2 commits into from
Dec 17, 2018

Conversation

tjmabey
Copy link
Contributor

@tjmabey tjmabey commented Dec 14, 2018

The 'get' function in cache doesn't check if localStorage exists and is accessible first.

Return null if _hasLocalStorage is false.

@JorgenEvens
Copy link
Member

HI @tjmabey,

Thanks for this fix!
Could you fix the linting errors before I merge this?

@JorgenEvens JorgenEvens self-assigned this Dec 15, 2018
@JorgenEvens JorgenEvens merged commit 038fdd0 into ambassify:master Dec 17, 2018
@JorgenEvens
Copy link
Member

Great! I will release an update later today.

@JorgenEvens JorgenEvens added this to the 3.5.0 milestone Dec 18, 2018
@JorgenEvens
Copy link
Member

This has been released as part of version v3.5.0!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@JorgenEvens JorgenEvens

Labels
enhancement
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tjmabey @JorgenEvens