Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add title attribute to avatar as property #176

Merged
merged 3 commits into from
Nov 17, 2019
Merged

Add title attribute to avatar as property #176

merged 3 commits into from
Nov 17, 2019

Conversation

fortwo
Copy link
Contributor

@fortwo fortwo commented Oct 18, 2019

No description provided.

@fortwo fortwo mentioned this pull request Oct 18, 2019
Closed
@JorgenEvens
Copy link
Member

Hi @one89, Thanks a lot for the PR. Would you mind adding two more things to the PR?

  • Add a title attribute here, so this also works for text-based avatars.
  • Add the typescript definition for the title attribute.

@fortwo
Copy link
Contributor Author

fortwo commented Oct 21, 2019

Hi @JorgenEvens,
just committed the requested changes :)

@JorgenEvens
Copy link
Member

Hi @one89,

Thanks for that, I'll review them as soon as I have the time.

@JorgenEvens JorgenEvens self-assigned this Nov 17, 2019
@JorgenEvens JorgenEvens merged commit 28df344 into ambassify:master Nov 17, 2019
@JorgenEvens JorgenEvens mentioned this pull request Dec 27, 2019
Merged
@JorgenEvens JorgenEvens added this to the 3.7.1 milestone Dec 27, 2019
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@JorgenEvens JorgenEvens

Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fortwo @JorgenEvens