Miscellaneous refactoring #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent Cargo rebuilding Amber even if no changes detected. This was a typo in the "rerun-if-changed" directive, which expects a directory, not an extended glob with "**".
Remove obsolete source code file "modules/command/expr.rs", which wasn't used by anything, and didn't compile anyway.
Remove temporary directories created by unit tests, to prevent "/tmp" becoming cluttered.
Miscellaneous refactoring, including (i) addition of trailing commas in some struct definitions/creations and vector assignments (makes for nicer PR diffs next time round), (ii) renaming of some variables, (iii) use of tuple destructuring, (iv) miscellaneous whitespace changes.