Some love to error handling. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Silent emit nil and do not raise `IndexError` on array out of bounds errors (like shopify liquid). - Only raise exceptions under `LiquidException` hierarchy. - Store exceptions instead of strings on `Context#errors`, so we can later add mode info on exception objects. - Do not raise exceptions on undefined variables, even on Strict mode (like shopify liquid). - Render the filter error on `FilterArgumentException` instead of raising (like shopify liquid), but raises on Strict mode, unlike Shopify liquid that does it only if rendering with `render!` - Fix some filters raising `LiquidException` instead of `FilterArgumentException`. - Add some documentation.
hugopl
commented
Jan 18, 2023
hugopl
force-pushed
the
error-handling
branch
from
e7602f6 to
6bc8f4e
Compare
crimson-knight
approved these changes
Jan 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexErroron array out of bounds errors (like shopify liquid).LiquidExceptionhierarchy.Context#errors, so we can later add mode info on exception objects.FilterArgumentExceptioninstead of raising (like shopify liquid), but raises on Strict mode, unlike Shopify liquid that does it only if rendering withrender!LiquidExceptioninstead ofFilterArgumentException.