Remove inline_script attribute from markup #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
approved these changes
Nov 27, 2024
|
5.17.1 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'inline_script' option is leaking out as an attribute for the input element. This is getting flagged by some a11y tools. For example, from https://validator.w3.org/nu:
Error: Attribute inline_script not allowed on element [input](https://html.spec.whatwg.org/multipage/#the-input-element) at this point.I don't think it is necessary in the markup, but alternatively we could move it to a data attribute if there's a need I'm not seeing.