Numpy 2.0 support #205
Merged
Numpy 2.0 support #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aganders3
commented
Jun 10, 2024
tests/test_geometry.py
Outdated
Comment on lines
233
to
235
| pytest.importorskip( | ||
| "phidl.font", reason="Testing of ttf/otf fonts requires the freetype package.", | ||
| exc_type=ImportError, |
There was a problem hiding this comment.
This could go in a separate PR, and this might not be the correct solution.
https://docs.pytest.org/en/8.2.x/deprecations.html#import-or-skip-import-error
aganders3
commented
Jun 10, 2024
|
Thank you for the PR! I've made a few modifications to satisfy the tests but otherwise looks great! |
|
Thanks! I'm not sure why pre-commit was not catching these issues locally for me but oh well. Pour one out for Python 3.7 support. |
|
No idea what was going wrong on the 3.7 but it was EOL anyway! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.0 is set to be released on June 16. I've been adding support in a couple other projects so figured I'd try to help out here if you're interested.
The process here was mainly to run the ruff plugin and fix what it caught. I used
np.float64where I needed to pick a float precision, because that seemed more common in your code.I also added the optional dependencies I found when running tests as extras, so you can install them with
pip install phidl[all](or[test]). Then I updated a few places that were causingDeprecationWarnings.