Allow for linear interpolation of offsets in phidl.path.transition
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns issue #208 where some users expect linear interpolation of the offset of CrossSection segments when setting
width_type="linear"in thephidl.path.transitionfunction. Current behavior is that only width inteprolation is affected by the argument but offset interpolation remains sinusoidal.In order to keep behavior identical for old code that may use this intentionally, this PR adds another kwarg
offset_typeto the function that behaves just likewidth_typebut setting interpolation for offsets instead, with the default value remaining"sine"for backwards comaptibility. This way, any combination of interpolation functions can be used for width and offset separately.