-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(rules): no-extra-parens #9
Merged
nellyk
merged 2 commits into
americanexpress:master
from
PatNeedham:feature/no-extra-parens
Feb 4, 2020
Merged
feat(rules): no-extra-parens #9
nellyk
merged 2 commits into
americanexpress:master
from
PatNeedham:feature/no-extra-parens
Feb 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hate being that guy telling folks "you have too many sets of parentheses here". Much better for the linter to do that. |
10xLaCroixDrinker
previously approved these changes
Jan 30, 2020
JamesSingleton
previously approved these changes
Jan 30, 2020
nellyk
previously approved these changes
Feb 3, 2020
@PatNeedham i recently merged another pull request which created a conflict on this, could you please resolve the conflict |
1e24ead
10xLaCroixDrinker
approved these changes
Feb 4, 2020
nellyk
approved these changes
Feb 4, 2020
Thank you @PatNeedham 🙌 |
oneamexbot
added a commit
that referenced
this pull request
Feb 7, 2020
🎉 This PR is included in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When my .eslintrc file is this:
The following code does not trigger any warnings / errors:
However including that extra rule directly via
makes the error appear:
