Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(rules): no-extra-parens #9

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

PatNeedham
Copy link
Contributor

When my .eslintrc file is this:

{
  "extends": "amex"
}

The following code does not trigger any warnings / errors:

      if (!(((((child.data)))))) {
        return child.children.map((c) => c.data);
      }

However including that extra rule directly via

{
  "extends": "amex",
  "rules": {
    "no-extra-parens": "error"
  }
}

makes the error appear:
image

@PatNeedham PatNeedham requested a review from a team as a code owner January 30, 2020 13:32
@PatNeedham
Copy link
Contributor Author

I hate being that guy telling folks "you have too many sets of parentheses here". Much better for the linter to do that.

JamesSingleton
JamesSingleton previously approved these changes Jan 30, 2020
@nellyk nellyk self-requested a review February 3, 2020 14:39
nellyk
nellyk previously approved these changes Feb 3, 2020
@nellyk
Copy link
Contributor

nellyk commented Feb 3, 2020

@PatNeedham i recently merged another pull request which created a conflict on this, could you please resolve the conflict

@nellyk
Copy link
Contributor

nellyk commented Feb 4, 2020

Thank you @PatNeedham 🙌

@nellyk nellyk merged commit a3afc72 into americanexpress:master Feb 4, 2020
oneamexbot added a commit that referenced this pull request Feb 7, 2020
# [11.1.0](v11.0.1...v11.1.0) (2020-02-07)

### Features

* **index:** disable jsx-one-expression-per-line ([#8](#8)) ([68e6d48](68e6d48))
* **rules:** no-extra-parens ([#9](#9)) ([a3afc72](a3afc72))
* **test:** allow prop spreading in test env ([85753fc](85753fc))
oneamexbot added a commit that referenced this pull request Feb 7, 2020
# [11.1.0](v11.0.1...v11.1.0) (2020-02-07)

### Features

* **index:** disable jsx-one-expression-per-line ([#8](#8)) ([68e6d48](68e6d48))
* **rules:** no-extra-parens ([#9](#9)) ([a3afc72](a3afc72))
* **test:** allow prop spreading in test env ([85753fc](85753fc))
oneamexbot added a commit that referenced this pull request Feb 7, 2020
# [11.2.0](v11.1.0...v11.2.0) (2020-02-07)

### Features

* **index:** disable jsx-one-expression-per-line ([#8](#8)) ([68e6d48](68e6d48))
* **rules:** no-extra-parens ([#9](#9)) ([a3afc72](a3afc72))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants