Add compression support in cli tool #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great at first glance! I'll do a full review later, thanks for taking care of this! |
happenslol
requested changes
Aug 12, 2019
There was a problem hiding this comment.
Alright, had some time to look at it now. Looks good to me all in all, I just think we should uniformly save in the same way. Maybe we should even look into using the png crate directly (for reading as well), since image sometimes randomly doesn't work for specific images.
happenslol
approved these changes
Aug 12, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compression support as per #26, it's a little bit awkward because oxipng does not allow it's input to be raw bytes but I worked around it.