Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add spacing presets to theme.json #350

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

madhusudhand
Copy link
Contributor

@madhusudhand madhusudhand commented Aug 7, 2024

Ref: #334, #366

This PR adds spacing presets to theme.json which creates preset css variables.
SASS function spacing() is replaced with the --wp--preset--spacing--* variables, and all css files are replaced by preset variables.

Steps to test:

  1. In the editor, verify the new spacing presets are available in the spacing tools.
image
  1. Verify the theme and all available blocks. They should not get effected.

Considerations:

  • It uses same schematics quarter, half, single, double and quad
  • However it is recommended to use relative naming such as x-small, small, medium etc..

Copy link
Contributor

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks for the PR!

@madhusudhand madhusudhand marked this pull request as ready for review August 8, 2024 05:10
@jaymcp jaymcp merged commit 2ff253b into amnestywebsite:develop Aug 8, 2024
1 check passed
@madhusudhand madhusudhand deleted the add/spacing-presets branch August 8, 2024 14:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants