Added support for PHP 8.4.

amphp · Nov 23, 2024 · f94a528 · f94a528
1 parent fe6b4dd
commit f94a528
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,6 +15,9 @@ jobs:
           - operating-system: 'ubuntu-latest'
             php-version: '8.2'
 
+          - operating-system: 'ubuntu-latest'
+            php-version: '8.4'
+
           - operating-system: 'windows-latest'
             php-version: '8.1'
             job-description: 'on Windows'

diff --git a/src/Cookie/ResponseCookie.php b/src/Cookie/ResponseCookie.php
@@ -158,14 +158,14 @@ private static function parseDate(string $date): ?\DateTimeImmutable
     /**
      * @param non-empty-string $name Name of the cookie.
      * @param string $value Value of the cookie.
-     * @param CookieAttributes $attributes Attributes of the cookie.
+     * @param CookieAttributes|null $attributes Attributes of the cookie.
      *
      * @throws InvalidCookieException If name or value is invalid.
      */
     public function __construct(
         private string $name,
         private string $value = '',
-        CookieAttributes $attributes = null,
+        ?CookieAttributes $attributes = null,
     ) {
         if (!\preg_match(self::NAME_REGEX, $name)) {
             throw new InvalidCookieException("Invalid cookie name: '{$name}'");