Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: LGTM return fix for falsy str #416

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: LGTM return fix for falsy str #416

merged 2 commits into from
Aug 10, 2021

Conversation

tevanko
Copy link
Contributor

@tevanko tevanko commented Aug 10, 2021

Summary

Ensures MetadataStorage.clear() returns false if no metadata existed

https://amplitude.atlassian.net/browse/AMP-38456

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@tevanko tevanko requested a review from ajhorst August 10, 2021 17:14
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request fixes 1 alert when merging 4ac5a6e into 564f656 - view on LGTM.com

fixed alerts:

  • 1 for Expression has no effect

kelvin-lu
kelvin-lu reviewed Aug 10, 2021
View reviewed changes
@tevanko tevanko changed the title fix <LGTM return fix for falsy str> fix: LGTM return fix for falsy str Aug 10, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request fixes 1 alert when merging 01e0081 into 564f656 - view on LGTM.com

fixed alerts:

  • 1 for Expression has no effect

@tevanko tevanko merged commit f744fe7 into main Aug 10, 2021
@tevanko tevanko deleted the AMP-38456 branch August 10, 2021 22:12
github-actions bot pushed a commit that referenced this pull request Aug 13, 2021
@amplitude-sdk-bot
chore(release): 8.5.0 [skip ci]
230fc65 
# [8.5.0](v8.4.0...v8.5.0) (2021-08-13)

### Bug Fixes

* LGTM return fix for falsy str ([#416](#416)) ([f744fe7](f744fe7))

### Features

* add sendBeacon support ([#412](#412)) ([0517038](0517038))
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kelvin-lu kelvin-lu kelvin-lu left review comments

@ajhorst ajhorst ajhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevanko @ajhorst @kelvin-lu