Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

MinifyHtml Transformer cannot be set to false #845

Closed
jwinkworth opened this issue Jun 22, 2020 · 1 comment · Fixed by #846
Closed

MinifyHtml Transformer cannot be set to false #845

jwinkworth opened this issue Jun 22, 2020 · 1 comment · Fixed by #846

Comments

@jwinkworth
Copy link

jwinkworth commented Jun 22, 2020 •
edited
Loading

amp-toolbox/packages/optimizer/lib/transformers/MinifyHtml.js

Line 41 in bf9cdb0

minify: !!config.minify || true,

Seems opts.minify will always result to true, regardless of what is passed into config variable.
sebastianbenz added a commit that referenced this issue Jun 22, 2020
@sebastianbenz
Fix: MinifyHtml cannot be disabled
f059dc4 
Fixes #845
@sebastianbenz sebastianbenz mentioned this issue Jun 22, 2020
Merged
sebastianbenz added a commit that referenced this issue Jun 22, 2020
@sebastianbenz
Fix: MinifyHtml cannot be disabled (#846)
39b4a90 
Fixes #845
@sebastianbenz
Copy link
Collaborator

sebastianbenz commented Jun 22, 2020 •
edited
Loading

Published in https://github.com/ampproject/amp-toolbox/releases/tag/v2.5.4

tharders pushed a commit that referenced this issue Aug 17, 2020
@sebastianbenz @tharders
Fix: MinifyHtml cannot be disabled (#846)
546102c 
Fixes #845
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: MinifyHtml cannot be disabled ampproject/amp-toolbox
2 participants
@sebastianbenz @jwinkworth